Cataclysm: Dark Days Ahead - Official Forums

Cataclysm: Dark Days Ahead => The Garage - Bug Reports and Technical Help => Topic started by: Ember on May 14, 2017, 09:00:12 AM

Title: conflicting mutations
Post by: Ember on May 14, 2017, 09:00:12 AM
you apparently can have slow feet and roadrunner at the same time
its a bit odd as one increases speed while the other reduces
build 6431

ver 0.C-22249
Title: Re: conflicting mutations
Post by: ZoneWizard on May 22, 2017, 04:42:47 PM
While perhaps a bug, considering the how the game will interpret this will be something of a "one cancels the other". So if the bug doesn't break anything it probably just cancels each other out or gives a tiny buff or debuff, depending on the exact hidden math of either.
Title: Re: conflicting mutations
Post by: Valiant on May 23, 2017, 07:57:20 PM
Created a PR to address this - https://github.com/CleverRaven/Cataclysm-DDA/pull/21101 (https://github.com/CleverRaven/Cataclysm-DDA/pull/21101).
Title: Re: conflicting mutations
Post by: Chezzo on May 24, 2017, 06:34:19 AM
You can also have ugly and pretty, and a whole lot of other conflicting mutations.
Title: Re: conflicting mutations
Post by: Solusphere on May 24, 2017, 07:18:12 AM
You can also have ugly and pretty, and a whole lot of other conflicting mutations.

If you have both of those at the same time, it's absolutely a bug. Ugly is in Pretty's cancelling mutations, and vice versa:

        "type" : "mutation",
        "id" : "PRETTY",
        "name" : "Pretty",
        "points" : 1,
        "ugliness" : -2,
        "description" : "You are a sight to behold.  NPCs who care about such thing will react more kindly to you.",
        "starting_trait" : true,
        "category" : ["MUTCAT_ALPHA", "MUTCAT_FELINE", "MUTCAT_LUPINE"],
        "cancels" : ["UGLY", "DEFORMED", "DEFORMED2", "DEFORMED3"],
        "changes_to" : ["BEAUTIFUL"]
Title: Re: conflicting mutations
Post by: Coolthulhu on May 31, 2017, 10:28:21 PM
Mutation system has some edge cases that aren't handled properly when inherent traits (the starting ones) are involved.
Here's one example:
https://github.com/CleverRaven/Cataclysm-DDA/issues/15725

This one looks a bit different, though.
Title: Re: conflicting mutations
Post by: ZoneWizard on June 14, 2017, 08:02:46 PM
So you are saying that the enabled start traits are not considered in regard to the cancel list? 0_o

If so. Core bug I assume?