Author Topic: Focus doesn't modify skill gains from books  (Read 241 times)

Offline Dreamer

  • Zombie Food
  • *
  • Posts: 3
    • View Profile
Focus doesn't modify skill gains from books
« on: September 04, 2017, 06:58:27 AM »
Version: 0.C-23708.

Focus that is drained from reading skillbooks doesn't influence anything.

As a new player, I was reading novels, eating potato chips, even playing "Find a Kitten" between sessions of reading skillbooks, to keep my morale and focus at reasonable level. I thought it was right idea to get enjoyment/focus and spend it to raise the skills. But then I made some tests and realized that skill gain from reading at 140 focus and 60 focus is the same..

If it works as intended, it's very unintuitive. And player can actually damage himself by not knowing it.

I belive either focus should modify skill gains from books or reading shouldn't drain focus, because it misleads the player. Since books require alot of time, second option is quite ok balance wise. But first option is better.
« Last Edit: September 04, 2017, 03:27:21 PM by Dreamer »

Offline MrBlinky

  • Zombie Food
  • *
  • Posts: 1
    • View Profile
Re: Focus doesn't modify skill gains from books
« Reply #1 on: September 26, 2017, 10:43:33 PM »
Can confirm this (using version 0.C-24106-gca0d5b0, SDL).
Tested a bunch of times by leveling a skill from 0 to 1, with the average focus of ~180  and ~40. Each on average taking ~4h.
Looking at the code, there is adjustment for other penalties, but seems to be none for focus.
I'm a new player myself, but this looks like this might be huge (one can read just as fast at very low focus values, and also the focus penalty from long reading does nothing if all you're doing is reading).
Note for anyone involved in development, assuming this is not intended, it seems ths could be fixed in a few lines of code. Check out the player::do_read() func in player.cpp (check below the "// Calculate experience gained" comment). adjust_for_focus() func in skill.cpp would be of use too (currently it's only used for non-books practice).
« Last Edit: September 26, 2017, 10:48:35 PM by MrBlinky »

Offline i2amroy

  • Contributor
  • Survivor
  • ****
  • Posts: 2783
  • Cats, ruling the world one dwarf at a time
    • View Profile
Re: Focus doesn't modify skill gains from books
« Reply #2 on: September 27, 2017, 10:07:08 PM »
Yeah, this looks more like an issue where the different ways of learning really need to be combined and standardized (i.e., everything calls practice at some point or something similar).

Offline §k

  • Survivor
  • ***
  • Posts: 512
    • View Profile
Re: Focus doesn't modify skill gains from books
« Reply #3 on: September 28, 2017, 02:40:07 AM »
Before I read this, I still read book while playing ukulele. That drops my speed to 80, making learning actually slower!